patch 9.0.0167: checking for text properties could be a bit more efficient

Problem:    Checking for text properties could be a bit more efficient.
Solution:   Return early when there are no text properties.  Update TODO
            items.
This commit is contained in:
Bram Moolenaar
2022-08-07 22:04:56 +01:00
parent 50652b0c5c
commit 38ea2733b4
2 changed files with 5 additions and 6 deletions

View File

@ -11,12 +11,8 @@
* Text properties implementation. See ":help text-properties".
*
* TODO:
* - Checking the text length to detect text properties is slow. Use a flag in
* the index, like DB_MARKED?
* - Also test line2byte() with many lines, so that ml_updatechunk() is taken
* into account.
* - Perhaps have a window-local option to disable highlighting from text
* properties?
*/
#include "vim.h"
@ -579,13 +575,14 @@ get_text_props(buf_T *buf, linenr_T lnum, char_u **props, int will_change)
text = ml_get_buf(buf, lnum, will_change);
textlen = STRLEN(text) + 1;
proplen = buf->b_ml.ml_line_len - textlen;
if (proplen == 0)
return 0;
if (proplen % sizeof(textprop_T) != 0)
{
iemsg(_(e_text_property_info_corrupted));
return 0;
}
if (proplen > 0)
*props = text + textlen;
*props = text + textlen;
return (int)(proplen / sizeof(textprop_T));
}

View File

@ -735,6 +735,8 @@ static char *(features[]) =
static int included_patches[] =
{ /* Add new patch number below this line */
/**/
167,
/**/
166,
/**/