Fastforwarding when in last subtitle now works as expected (bug #318),

from chmmravatar


git-svn-id: svn://svn.code.sf.net/p/sc2/code/trunk@921 8092fc87-c524-0410-9efc-e669fe64eaf9

sc2/ChangeLog

@@ -1,4 +1,6 @@
 Changes towards version 0.3:
+- Fastforwarding when in last subtitle now works as expected (bug #318),
+  from chmmravatar
 - Fixed MixSDL buffer underrun handling (bug #211) -Mika
 - Fix issue with caps lock and num lock preventing planet scan
   and lander message skipping (bug #299), from chmmravatar

sc2/src/sc2code/comm.c

@@ -1332,8 +1332,15 @@ SpewPhrases (COUNT wait_track)
 			if (GetInputXComponent (InputState) > 0)
 			{
 				SetSliderImage (SetAbsFrameIndex (ActivityFrame, 3));
-				if (optSmoothScroll == OPT_PC && InputState != LastInputState)
+				if (optSmoothScroll == OPT_PC && InputState != LastInputState
-					FastForward_Page ();
+						&& !FastForward_Page ())
+				{
+					SetSliderImage (SetAbsFrameIndex (ActivityFrame, 8));
+					JumpTrack ();
+					CommData.AlienFrame = F;
+					do_subtitles ((void *)~0);
+					return (FALSE);
+				}
 				else if (optSmoothScroll == OPT_3DO)
 					FastForward_Smooth ();
 				ContinuityBreak = TRUE;

sc2/src/sc2code/libs/sound/trackplayer.c

@@ -643,7 +643,7 @@ FastForward_Smooth ()
 	}
 }
 
-void
+int
 FastForward_Page ()
 {
 	if (sound_sample)
@@ -658,9 +658,16 @@ FastForward_Page ()
 			PlayStream (sound_sample,
 					SPEECH_SOURCE, false,
 					speechVolumeScale != 0.0f, true);
+			UnlockMutex (soundSource[SPEECH_SOURCE].stream_mutex);
+			return TRUE;
+		}
+		else //means there are no more pages left
+		{
+			UnlockMutex (soundSource[SPEECH_SOURCE].stream_mutex);
+			return FALSE;
 		}
-		UnlockMutex (soundSource[SPEECH_SOURCE].stream_mutex);
 	}
+	return TRUE;
 }
 
 // processes sound data to oscilloscope

sc2/src/sc2code/libs/sound/trackplayer.h

@@ -26,7 +26,7 @@ void PauseTrack(void);
 COUNT PlayingTrack(void);
 void JumpTrack(void);
 void FastForward_Smooth(void);
-void FastForward_Page(void);
+int FastForward_Page(void);
 void FastReverse_Smooth(void);
 void FastReverse_Page(void);
 void StopTrack(void);