From ca0ffc0d63727850c520a80929698e4c199b17f4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dominique=20Pell=C3=A9?= Date: Sun, 24 Sep 2023 22:57:41 +0200 Subject: [PATCH] patch 9.0.1931: make test_compilers fails on ubuntu MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Problem: make test_compilers fails on ubuntu Solution: set LC_ALL=C fix: make test_compiler failed on xubuntu 22.04.3 Problem: 'make test_compiler' failed on Linux xubuntu 22.04.3 but succeeded on e.g. macOS. To reproduce: ``` $ ./configure --with-features=huge --enable-gui=no --enable-perlinterp=yes $ make -j12 $ cd vim/src/testdir $ make test_compiler ...snip... Found errors in Test_compiler(): command line..script /home/dope/sb/vim/src/testdir/runtest.vim[601]..function RunTheTest[54]..Test_compiler line 24: command did not fail: clist command line..script /home/dope/sb/vim/src/testdir/runtest.vim[601]..function RunTheTest[54]..Test_compiler line 30: Pattern '\\n \\d\\+ Xfoo.pl:3: Global symbol "$foo" requires explicit package name' does not match '\n19 Xfoo.pl:3: Global symbol "$foo" requires explicit package name (did you forget to declare "my $foo"?)' make: *** [Makefile:70: test_compiler] Error 1 ``` Solution: set `LC_ALL` to "C" in `Test_compiler()` closes: #13173 Signed-off-by: Christian Brabandt Co-authored-by: Dominique Pellé --- src/testdir/test_compiler.vim | 7 +++---- src/version.c | 2 ++ 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/testdir/test_compiler.vim b/src/testdir/test_compiler.vim index 781bac67a9..4b710df07c 100644 --- a/src/testdir/test_compiler.vim +++ b/src/testdir/test_compiler.vim @@ -7,10 +7,8 @@ func Test_compiler() CheckExecutable perl CheckFeature quickfix - " $LANG changes the output of Perl. - if $LANG != '' - unlet $LANG - endif + let save_LC_ALL = $LC_ALL + let $LC_ALL= "C" " %:S does not work properly with 'shellslash' set let save_shellslash = &shellslash @@ -40,6 +38,7 @@ func Test_compiler() let &shellslash = save_shellslash call delete('Xfoo.pl') bw! + let $LC_ALL = save_LC_ALL endfunc func GetCompilerNames() diff --git a/src/version.c b/src/version.c index f30b08e4ae..b5ffdd1fe6 100644 --- a/src/version.c +++ b/src/version.c @@ -699,6 +699,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ +/**/ + 1931, /**/ 1930, /**/