adam/vim
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

patch 9.1.1233: Coverity warns about NULL pointer when triggering WinResized

Browse Source 
Problem:  Coverity warns about NULL pointer when triggering WinResized
Solution: Add OOM checks for windows_list like for scroll_dict. Remove
          void casts that are unnecessary after 9.1.1084 (zeertzjq).

closes: #16959

Signed-off-by: zeertzjq <zeertzjq@outlook.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
This commit is contained in:
zeertzjq
2025-03-24 20:22:23 +01:00
committed by Christian Brabandt
parent 92e109fc13
commit b42b9fc41f
2 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/window.c
View File

@ -3285,7 +3285,8 @@ may_trigger_win_scrolled_resized(void)
{
// Create the list for v:event.windows before making the snapshot.
windows_list = list_alloc_with_items(size_count);
(void)check_window_scroll_resize(NULL, NULL, NULL, windows_list, NULL);
if (windows_list != NULL)
check_window_scroll_resize(NULL, NULL, NULL, windows_list, NULL);
}
dict_T *scroll_dict = NULL;
@ -3296,8 +3297,7 @@ may_trigger_win_scrolled_resized(void)
if (scroll_dict != NULL)
{
scroll_dict->dv_refcount = 1;
(void)check_window_scroll_resize(NULL, NULL, NULL, NULL,
scroll_dict);
check_window_scroll_resize(NULL, NULL, NULL, NULL, scroll_dict);
}
}
#endif
@ -3314,7 +3314,11 @@ may_trigger_win_scrolled_resized(void)
recursive = TRUE;
// If both are to be triggered do WinResized first.
if (trigger_resize)
if (trigger_resize
#ifdef FEAT_EVAL
&& windows_list != NULL
#endif
)
{
#ifdef FEAT_EVAL
save_v_event_T save_v_event;