patch 9.0.2118: [security]: avoid double-free in get_style_font_variants
Problem: [security]: avoid double-free Solution: Only fee plain_font, when it is not the same as bold_font When plain_font == bold_font and bold_font is not NULL, we may end up trying to free bold_font again, which already has been freed a few lines above. So only free bold_font, when the condition gui.font_can_bold is true, which means that bold_font is not pointing to plain_font (so it needs to be freed separately). Signed-off-by: Christian Brabandt <cb@256bit.org>
This commit is contained in:
		| @ -5048,7 +5048,8 @@ get_styled_font_variants(void) | |||||||
|     } |     } | ||||||
|  |  | ||||||
|     pango_font_description_free(bold_font_desc); |     pango_font_description_free(bold_font_desc); | ||||||
|     g_object_unref(plain_font); |     if (bold_font != NULL && gui.font_can_bold) | ||||||
|  | 	g_object_unref(plain_font); | ||||||
| } | } | ||||||
|  |  | ||||||
| static PangoEngineShape *default_shape_engine = NULL; | static PangoEngineShape *default_shape_engine = NULL; | ||||||
|  | |||||||
| @ -704,6 +704,8 @@ static char *(features[]) = | |||||||
|  |  | ||||||
| static int included_patches[] = | static int included_patches[] = | ||||||
| {   /* Add new patch number below this line */ | {   /* Add new patch number below this line */ | ||||||
|  | /**/ | ||||||
|  |     2118, | ||||||
| /**/ | /**/ | ||||||
|     2117, |     2117, | ||||||
| /**/ | /**/ | ||||||
|  | |||||||
		Reference in New Issue
	
	Block a user