adam/vim
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

patch 9.1.1581: possible memory leak in vim9generics.c

Browse Source 
Problem:  possible memory leak in vim9generics.c
Solution: Free ret_free if ga_grow() fails and before returning
          (Lidong Yan).

In parse_generic_func_type_args() at vim9generics.c, we allocate memory
in ret_name and should free it by calling vim_free(ret_free). If
ga_grow on gfatab->gfat_args failed, we forget to call vim_free(ret_free)
thus would cause a leak. Add vim_free(ret_free) before return NULL.

closes: #17821

Signed-off-by: Lidong Yan <yldhome2d2@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
This commit is contained in:
Lidong Yan
2025-07-22 18:15:57 +02:00
committed by Christian Brabandt
parent 13e1af7de9
commit 97194523d5
2 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/version.c
View File

@ -719,6 +719,8 @@ static char *(features[]) =
static int included_patches[] = static int included_patches[] =
{ /* Add new patch number below this line */ { /* Add new patch number below this line */
/**/
1581,
/**/ /**/
1580, 1580,
/**/ /**/

4
src/vim9generics.c
View File

@ -305,8 +305,10 @@ parse_generic_func_type_args(
char *ret_name = type_name(type_arg, &ret_free); char *ret_name = type_name(type_arg, &ret_free);
// create space for the name and the new type // create space for the name and the new type
if (ga_grow(&gfatab->gfat_args, 1) == FAIL) if (ga_grow(&gfatab->gfat_args, 1) == FAIL) {
vim_free(ret_free);
return NULL; return NULL;
}
generic_arg = (generic_T *)gfatab->gfat_args.ga_data + generic_arg = (generic_T *)gfatab->gfat_args.ga_data +
gfatab->gfat_args.ga_len; gfatab->gfat_args.ga_len;
gfatab->gfat_args.ga_len++; gfatab->gfat_args.ga_len++;