diff --git a/src/buffer.c b/src/buffer.c index 748ffdaa7e..49db39d8f6 100644 --- a/src/buffer.c +++ b/src/buffer.c @@ -1371,8 +1371,11 @@ do_buffer_ext( } else { + int help_only = (flags & DOBUF_SKIPHELP) != 0 && buf->b_help; + bp = NULL; - while (count > 0 || (!unload && !buf->b_p_bl && bp != buf)) + while (count > 0 || (bp != buf && !unload + && !(help_only ? buf->b_help : buf->b_p_bl))) { // remember the buffer where we start, we come back there when all // buffers are unlisted. @@ -1390,14 +1393,17 @@ do_buffer_ext( if (buf == NULL) buf = lastbuf; } + // Avoid non-help buffers if the starting point was a help buffer + // and vice-versa. // Don't count unlisted buffers. - // Avoid non-help buffers if the starting point was a non-help buffer and - // vice-versa. - if (unload || (buf->b_p_bl - && ((flags & DOBUF_SKIPHELP) == 0 || buf->b_help == bp->b_help))) + if (unload + || (help_only + ? buf->b_help + : (buf->b_p_bl && ((flags & DOBUF_SKIPHELP) == 0 + || !buf->b_help)))) { - --count; - bp = NULL; // use this buffer as new starting point + --count; + bp = NULL; // use this buffer as new starting point } if (bp == buf) { diff --git a/src/testdir/test_buffer.vim b/src/testdir/test_buffer.vim index d6d668799f..e16a537ef2 100644 --- a/src/testdir/test_buffer.vim +++ b/src/testdir/test_buffer.vim @@ -167,6 +167,17 @@ func Test_bnext_bprev_help() b XHelp1 blast | call assert_equal(b4, bufnr()) + " Cycling through help buffers works even if they aren't listed. + b XHelp1 + setlocal nobuflisted + bnext | call assert_equal(b3, bufnr()) + bnext | call assert_equal(b1, bufnr()) + bprev | call assert_equal(b3, bufnr()) + setlocal nobuflisted + bprev | call assert_equal(b1, bufnr()) + bprev | call assert_equal(b3, bufnr()) + bnext | call assert_equal(b1, bufnr()) + %bwipe! endfunc diff --git a/src/version.c b/src/version.c index ff47328d42..d1923b1dbe 100644 --- a/src/version.c +++ b/src/version.c @@ -719,6 +719,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ +/**/ + 1599, /**/ 1598, /**/