From 41cddfa177096168ea7f7c4f2a2857c0d76ce5d8 Mon Sep 17 00:00:00 2001 From: Yegappan Lakshmanan Date: Sat, 3 May 2025 19:11:45 +0200 Subject: [PATCH] patch 9.1.1362: Vim9: type ignored when adding tuple to instance list var Problem: Vim9: type ignored when adding tuple to instance list var (Lifepillar) Solution: When getting the typval of class and object member variables, set the variable type (Yegappan Lakshmanan) fixes: #17236 closes: #17244 Signed-off-by: Yegappan Lakshmanan Signed-off-by: Christian Brabandt --- src/testdir/test_vim9_class.vim | 69 +++++++++++++++++++++++++++++++++ src/version.c | 2 + src/vim9class.c | 2 + 3 files changed, 73 insertions(+) diff --git a/src/testdir/test_vim9_class.vim b/src/testdir/test_vim9_class.vim index e854571e5f..3ba467b238 100644 --- a/src/testdir/test_vim9_class.vim +++ b/src/testdir/test_vim9_class.vim @@ -13084,4 +13084,73 @@ def Test_object_of_class_type() \ 'E1353: Class name not found: ']) enddef +" Test for the object and class member type +def Test_obj_class_member_type() + var lines =<< trim END + vim9script + class L + var l: list + endclass + var obj_L = L.new([10, 20]) + assert_equal('list', typename(obj_L.l)) + obj_L.l->add('a') + END + v9.CheckSourceFailure(lines, 'E1012: Type mismatch; expected number but got string', 7) + + lines =<< trim END + vim9script + class T + var t: list> + endclass + var obj_T = T.new([('a',), ('b',)]) + assert_equal('list>', typename(obj_T.t)) + obj_T.t->add([('c', 10, true)]) + END + v9.CheckSourceFailure(lines, 'E1012: Type mismatch; expected tuple but got list>', 7) + + lines =<< trim END + vim9script + class D + var d: dict + endclass + var obj_D = D.new({a: 10, b: 20}) + assert_equal('dict', typename(obj_D.d)) + obj_D.d->extend({c: 'C'}) + END + v9.CheckSourceFailure(lines, 'E1013: Argument 2: type mismatch, expected dict but got dict in extend()', 7) + + lines =<< trim END + vim9script + class L + public static var l: list + endclass + L.l = [10, 20] + assert_equal('list', typename(L.l)) + L.l->add('a') + END + v9.CheckSourceFailure(lines, 'E1012: Type mismatch; expected number but got string', 7) + + lines =<< trim END + vim9script + class T + public static var t: list> + endclass + T.t = [('a',), ('b',)] + assert_equal('list>', typename(T.t)) + T.t->add([('c', 10, true)]) + END + v9.CheckSourceFailure(lines, 'E1012: Type mismatch; expected tuple but got list>', 7) + + lines =<< trim END + vim9script + class D + public static var d: dict + endclass + D.d = {a: 10, b: 20} + assert_equal('dict', typename(D.d)) + D.d->extend({c: 'C'}) + END + v9.CheckSourceFailure(lines, 'E1013: Argument 2: type mismatch, expected dict but got dict in extend()', 7) +enddef + " vim: ts=8 sw=2 sts=2 expandtab tw=80 fdm=marker diff --git a/src/version.c b/src/version.c index 7d29d7020b..4dc628f30f 100644 --- a/src/version.c +++ b/src/version.c @@ -704,6 +704,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ +/**/ + 1362, /**/ 1361, /**/ diff --git a/src/vim9class.c b/src/vim9class.c index 560c5ae283..a82cc13329 100644 --- a/src/vim9class.c +++ b/src/vim9class.c @@ -2928,11 +2928,13 @@ get_member_tv( object_T *obj = rettv->vval.v_object; typval_T *tv = (typval_T *)(obj + 1) + m_idx; copy_tv(tv, rettv); + set_tv_type(rettv, m->ocm_type); object_unref(obj); } else { copy_tv(&cl->class_members_tv[m_idx], rettv); + set_tv_type(rettv, m->ocm_type); class_unref(cl); }