From 36544c408e9b5a2d7ca480e34936d274df0331cd Mon Sep 17 00:00:00 2001 From: Shay Date: Thu, 25 Sep 2025 05:57:11 +0000 Subject: [PATCH] patch 9.1.1789: MS-Windows: using wrong check for bold font Problem: MS-Windows: using wrong check for bold font (after v9.1.1347) Solution: Test if lf.lfWeight == FW_BOLD instead of a simple truthiness test (Shay) Commit 411ae58 replaced an operator conditional `if lf.lfWeight == FW_BOLD` with a truthiness check `if lf.lfWeight` This conditional determines whether `:b` is inserted into the value of `guifont`. The truthiness check allowed both FW_STANDARD and FW_BOLD font weights to trigger the insertion of `:b` into the `guifont` string. This commit restores the `== FW_BOLD` condition. fixes: #18383 closes: #18397 Signed-off-by: Shay Signed-off-by: Hirohito Higashi Signed-off-by: Christian Brabandt --- src/gui_w32.c | 2 +- src/version.c | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gui_w32.c b/src/gui_w32.c index a29fa91b0a..1ee4ab1677 100644 --- a/src/gui_w32.c +++ b/src/gui_w32.c @@ -3719,7 +3719,7 @@ logfont2name(LOGFONTW lf) res_size - res_len, "%s%s%s%s", lf.lfItalic ? ":i" : "", - lf.lfWeight ? ":b" : "", + lf.lfWeight == FW_BOLD ? ":b" : "", lf.lfUnderline ? ":u" : "", lf.lfStrikeOut ? ":s" : ""); diff --git a/src/version.c b/src/version.c index bad197898e..9531ed0d26 100644 --- a/src/version.c +++ b/src/version.c @@ -729,6 +729,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ +/**/ + 1789, /**/ 1788, /**/