From 3255af850e8bab35c30fce4177bb5ba4a941e6ce Mon Sep 17 00:00:00 2001 From: Jim Zhou Date: Thu, 27 Feb 2025 19:29:50 +0100 Subject: [PATCH] patch 9.1.1157: command completion wrong for input() Problem: command completion wrong for input() (Cdrman Fu) Solution: Set commandline completion context explicitly (Jim Zhou) fixes #16723 closes: #16733 Signed-off-by: Jim Zhou Signed-off-by: Christian Brabandt --- src/cmdexpand.c | 14 ++++++++++++-- src/testdir/test_functions.vim | 5 +++++ src/version.c | 2 ++ 3 files changed, 19 insertions(+), 2 deletions(-) diff --git a/src/cmdexpand.c b/src/cmdexpand.c index c14eee2c93..9f24429f46 100644 --- a/src/cmdexpand.c +++ b/src/cmdexpand.c @@ -229,8 +229,18 @@ nextwild( if (xp->xp_numfiles == -1) { - set_expand_context(xp); - cmd_showtail = expand_showtail(xp); +#ifdef FEAT_EVAL + if (ccline->input_fn && ccline->xp_context == EXPAND_COMMANDS) + { + // Expand commands typed in input() function + set_cmd_context(xp, ccline->cmdbuff, ccline->cmdlen, ccline->cmdpos, FALSE); + } + else +#endif + { + set_expand_context(xp); + } + cmd_showtail = expand_showtail(xp); } if (xp->xp_context == EXPAND_UNSUCCESSFUL) diff --git a/src/testdir/test_functions.vim b/src/testdir/test_functions.vim index 6928cda8d4..724fda05c3 100644 --- a/src/testdir/test_functions.vim +++ b/src/testdir/test_functions.vim @@ -2244,6 +2244,11 @@ func Test_input_func() call assert_fails("call input('F:', '', 'invalid')", 'E180:') call assert_fails("call input('F:', '', [])", 'E730:') + + " Test for using 'command' as the completion function + call feedkeys(":let c = input('Command? ', '', 'command')\" + \ .. "echo bufnam\\", 'xt') + call assert_equal('echo bufname(', c) endfunc " Test for the inputdialog() function diff --git a/src/version.c b/src/version.c index ef3ca2e38e..94db286ee6 100644 --- a/src/version.c +++ b/src/version.c @@ -704,6 +704,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ +/**/ + 1157, /**/ 1156, /**/