From 2f8cbc4b225ba707c3926070a3f133eb0473aed2 Mon Sep 17 00:00:00 2001 From: Bram Moolenaar Date: Wed, 16 Sep 2020 17:22:59 +0200 Subject: [PATCH] patch 8.2.1695: Vim9: crash when using varargs type "any" Problem: Vim9: crash when using varargs type "any". Solution: Check if uf_va_type is &t_any. (closes #6957) --- src/testdir/test_vim9_func.vim | 9 +++++++++ src/version.c | 2 ++ src/vim9compile.c | 4 ++-- src/vim9execute.c | 1 + 4 files changed, 14 insertions(+), 2 deletions(-) diff --git a/src/testdir/test_vim9_func.vim b/src/testdir/test_vim9_func.vim index 563e281a08..f0c5e91390 100644 --- a/src/testdir/test_vim9_func.vim +++ b/src/testdir/test_vim9_func.vim @@ -319,6 +319,15 @@ def Test_call_def_varargs() END CheckScriptSuccess(lines) + lines =<< trim END + vim9script + def Func(...l: any) + echo l + enddef + Func(0) + END + CheckScriptSuccess(lines) + lines =<< trim END vim9script def Func(...l: list) diff --git a/src/version.c b/src/version.c index c3efafd0bb..be62786059 100644 --- a/src/version.c +++ b/src/version.c @@ -750,6 +750,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ +/**/ + 1695, /**/ 1694, /**/ diff --git a/src/vim9compile.c b/src/vim9compile.c index 075bd12c45..338fbc6391 100644 --- a/src/vim9compile.c +++ b/src/vim9compile.c @@ -1430,8 +1430,8 @@ generate_CALL(cctx_T *cctx, ufunc_T *ufunc, int pushed_argcount) continue; expected = ufunc->uf_arg_types[i]; } - else if (ufunc->uf_va_type == NULL) - // possibly a lambda + else if (ufunc->uf_va_type == NULL || ufunc->uf_va_type == &t_any) + // possibly a lambda or "...: any" expected = &t_any; else expected = ufunc->uf_va_type->tt_member; diff --git a/src/vim9execute.c b/src/vim9execute.c index ddc20bce8f..7c8f77977c 100644 --- a/src/vim9execute.c +++ b/src/vim9execute.c @@ -829,6 +829,7 @@ call_def_function( // Check the type of the list items. tv = STACK_TV_BOT(-1); if (ufunc->uf_va_type != NULL + && ufunc->uf_va_type != &t_any && ufunc->uf_va_type->tt_member != &t_any && tv->vval.v_list != NULL) {