adam/flenser
SHA256
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Properly manage lifecycle for ClientInfo.

Browse Source
This commit is contained in:
ADAM David Alan Martin
2026-01-10 00:06:54 -05:00
parent c3a9c536a3
commit d791913a7f
1 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
dpi/file.cc
+7 -8
View File
@@ -66,14 +66,15 @@
#define FILE_ERR 16 /* Operation error */ #define FILE_ERR 16 /* Operation error */
typedef enum { enum FileState
{
st_start = 10, st_start = 10,
st_dpip, st_dpip,
st_http, st_http,
st_content, st_content,
st_done, st_done,
st_err st_err
} FileState; };
struct FileInfo { struct FileInfo {
std::string full_path; std::string full_path;
@@ -891,9 +892,7 @@ static void termination_handler(int signum)
*/ */
static ClientInfo *File_add_client(int sock_fd) static ClientInfo *File_add_client(int sock_fd)
{ {
ClientInfo *new_client; auto new_client = std::make_unique< ClientInfo >();
new_client = new ClientInfo;
new_client->sh = a_Dpip_dsh_new(sock_fd, sock_fd, 8*1024); new_client->sh = a_Dpip_dsh_new(sock_fd, sock_fd, 8*1024);
new_client->orig_url = NULL; new_client->orig_url = NULL;
new_client->filename = NULL; new_client->filename = NULL;
@@ -905,9 +904,9 @@ static ClientInfo *File_add_client(int sock_fd)
new_client->flags = FILE_READ; new_client->flags = FILE_READ;
new_client->old_style = OLD_STYLE; new_client->old_style = OLD_STYLE;
dList_append(Clients, new_client); dList_append(Clients, new_client.get());
return new_client; return new_client.release();
} }
/* /*
@@ -925,7 +924,7 @@ static void File_remove_client(ClientInfo *client)
dFree(client->filename); dFree(client->filename);
File_dillodir_free(client->d_dir); File_dillodir_free(client->d_dir);
dFree(client); delete client;
} }
/* /*