From 3e8b8bf30e233e0c3d0fb1ff3c6124e8b221a55e Mon Sep 17 00:00:00 2001 From: Meep-Eep Date: Wed, 28 Dec 2011 19:40:24 +0000 Subject: [PATCH] Cleanup, simplify, from Louis Delacroix. git-svn-id: svn://svn.code.sf.net/p/sc2/code/trunk@3716 8092fc87-c524-0410-9efc-e669fe64eaf9 --- sc2/src/libs/memlib.h | 8 +++--- sc2/src/libs/memory/w_memlib.c | 45 +++++++++------------------------- 2 files changed, 17 insertions(+), 36 deletions(-) diff --git a/sc2/src/libs/memlib.h b/sc2/src/libs/memlib.h index 52234f37c..697b7317f 100644 --- a/sc2/src/libs/memlib.h +++ b/sc2/src/libs/memlib.h @@ -19,6 +19,8 @@ #ifndef _MEMLIB_H #define _MEMLIB_H +#include + #include "types.h" #if defined(__cplusplus) @@ -28,10 +30,10 @@ extern "C" { extern bool mem_init (void); extern bool mem_uninit (void); -extern void *HMalloc (int size); +extern void *HMalloc (size_t size); extern void HFree (void *p); -extern void *HCalloc (int size); -extern void *HRealloc (void *p, int size); +extern void *HCalloc (size_t size); +extern void *HRealloc (void *p, size_t size); #if defined(__cplusplus) } diff --git a/sc2/src/libs/memory/w_memlib.c b/sc2/src/libs/memory/w_memlib.c index a4c55639c..342e34ef3 100644 --- a/sc2/src/libs/memory/w_memlib.c +++ b/sc2/src/libs/memory/w_memlib.c @@ -38,68 +38,47 @@ mem_uninit (void) } void * -HMalloc (int size) +HMalloc (size_t size) { - void *p; - - if (size == 0) - return NULL; - - if (size < 0) - { - log_add (log_Fatal, "HMalloc() FATAL: " - "request for negative amount of memory %d!", size); - fflush (stderr); - explode (); - } - - p = malloc (size); - if (p == NULL) + void *p = malloc (size); + if (p == NULL && size > 0) { log_add (log_Fatal, "HMalloc() FATAL: out of memory."); fflush (stderr); explode (); } - return (p); + + return p; } void HFree (void *p) { - if (p) - { - free (p); - } + free (p); } void * -HCalloc (int size) +HCalloc (size_t size) { void *p; p = HMalloc (size); memset (p, 0, size); - return (p); + return p; } void * -HRealloc (void *p, int size) +HRealloc (void *p, size_t size) { - if (size < 0) - { - log_add (log_Fatal, "HRealloc() FATAL: " - "request for negative amount of memory %d!", size); - fflush (stderr); - explode (); - } - p = realloc (p, size); - if (!p && size > 0) + if (p == NULL && size > 0) { log_add (log_Fatal, "HRealloc() FATAL: out of memory."); fflush (stderr); explode (); } + return p; } +